On 11/21/19 6:11 AM, Mark Brown wrote:
On Thu, Nov 21, 2019 at 01:02:38PM +0100, Jaroslav Kysela wrote:
Dne 21. 11. 19 v 12:51 Mark Brown napsal(a):
On Wed, Nov 20, 2019 at 06:44:34PM +0100, Jaroslav Kysela wrote:
- /* make up dmi long name as: vendor.product.version.board */
+ /* make up dmi long name as: vendor-product-version-board */
I'm worried about this from an ABI point of view with people's UCM
files. But perhaps I'm worrying about nothing?
this is just the C comment fix. The long name is already in
vendor-product-version-board - no dots as delimiters (but does are allowed
in the fields like version strings). This code improvement does not change
the format of the generated long name string from the DMI information.
Ah, it looked from my initial scan like it was being changed as a result
of the factoring out of the append code.
I had the same reaction on v1, it's just cleaning up a bad comment indeed.
This looks good to me, especially the removal of redundant parts, so for
the patch 1..2
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx>
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
