On Tue, Nov 19, 2019 at 04:34:16PM +0300, Dan Carpenter wrote: > There is only one real bug in my review but there is just a lot of clean > up left. Can you have a co-worker review your patch before resending? > The patch 1/6 looks pretty good now but I haven't seen patches 2-5 so > I'm worried there is a lot of cleanup left to do. Please, yes - there's a *lot* of fairly minor problems that are coming up in review each time before I've even had a chance to glance at it. You might also want to consider looking to make smaller, more incremental changes towards the goal (eg, refactoring the drivers in ways that will allow multiple instances more easily) which will be easier for both you and reviewers to check thoroughly.
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
