On Wed, Nov 13, 2019 at 7:13 PM Takashi Iwai <tiwai@xxxxxxx> wrote: > On Wed, 13 Nov 2019 18:19:56 +0100, Arnd Bergmann wrote: > > On Wed, Nov 13, 2019 at 6:04 PM Takashi Iwai <tiwai@xxxxxxx> wrote: > > > I don't mind much about that, so it's up to you -- we can fold this > > > change into the patch that actually adds or modifies the ioctl, too. > > > > I've added the patch below to the end of the series now, will repost > > the series after no more comments come in for this version. > > Having a single patch to update the version seems better than updating > > it multiple times with each patch touching the ABI in this series. > > I wasn't clear enough. Each ALSA device API has a protocol version, > not only PCM, so we need updating SNDRV_RAWMIDI_VERSION and > SNDRV_TIMER_VERSION as well. Ok, I see. I've updated the patch to include all three, and adapted the changelog text. There are still multiple changes for the PCM interface, so this avoids having the version number change attached to half the code changes. Arnd _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx https://mailman.alsa-project.org/mailman/listinfo/alsa-devel