On 11/12/2019 6:10 PM, Mark Brown wrote:
On Tue, Nov 12, 2019 at 02:02:37PM +0100, Pawel Harlozinski wrote:
/* Disable jack detection */
regmap_update_bits(rt274->regmap, RT274_EAPD_GPIO_IRQ_CTRL,
RT274_IRQ_EN, RT274_IRQ_DIS);
-
+ disable_irq(rt274->i2c->irq);
return 0;
Shouldn't the register update above be suppressing interrupts?
For rt274 disable_irq is also needed, otherwise we're getting flood of
irq's in case of not loaded machine board.
disable_irq() is a bit of a hammer and interferes with things like
possible share use.
This irq should be handled in codec code anyway - control of jack detect
events from non-codec code is done with set_jack.
Similar solutions for jack report irq enable/disable flow are
implemented in rt5640 and rt5651.
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
