Re: [PATCH] sscape: driver extension to 2nd DMA and WSS port

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 17 Sep 2007 13:01:42 +0200
Takashi Iwai <tiwai@xxxxxxx> wrote:


> I reject your patch not because of coding style but it changes the
> existing module option :-)
> 
> Can you keep the option dma and just add dma2?

Yes, of course.

> 
> Also, you changed the initialization of port[].  Any reason?  Is the
> current code broken in that way?
> 
No, the code is not broken. The changed way is exactly the same but shorter.
>From the sound/initval.h:

#define SNDRV_DEFAULT_PORT      { [0 ... (SNDRV_CARDS-1)] = SNDRV_AUTO_PORT }

I can leave old initialization if you prefer.

Regards,
Krzysztof
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux