On 09/17/2007 10:14 AM, Clemens Ladisch wrote:
Krzysztof Helt wrote:
Should the OPL4 detection has the same fallback or just all Opti cards
should search the FM chip at the range + 8 address?
It appears a fallback shoudn't be needed because the chip always returns
a range suitable for an OPL4.
Since an OPL3 range is never larger than 8 bytes, and OPL4 needs 16
bytes, we could add 8 to get the FM address _if_ the range is at least 16
bytes; thus we are safe even if a chip publishes an OPL3-only range.
At least 16 won't do -- the OPTi chip provides a 12-byte range. More than 8
would work, but just +8 is fine. I have all OPTi ISA-PnP chips (924, 925,
931, 933) and more aren't going to be produced. The 0x380 base is what it
calls the OPL4Base and ALBase (AdLib) is at 0x388.
The chip can defer to external FM it seems, but even if there are OPTi/OPL4
combo's out there in the wild (I sort of doubt it) the driver's just doing
opl3 anyway. ie, still needs just the +8.
Rene.
diff --git a/sound/isa/opti9xx/opti92x-ad1848.c b/sound/isa/opti9xx/opti92x-ad1848.c
index 60c120f..8bda47a 100644
--- a/sound/isa/opti9xx/opti92x-ad1848.c
+++ b/sound/isa/opti9xx/opti92x-ad1848.c
@@ -1732,11 +1732,11 @@ static int __devinit snd_card_opti9xx_pnp(struct snd_opti9xx *chip,
#ifdef OPTi93X
port = pnp_port_start(pdev, 0) - 4;
- fm_port = pnp_port_start(pdev, 1);
+ fm_port = pnp_port_start(pdev, 1) + 8;
#else
if (pid->driver_data != 0x0924)
port = pnp_port_start(pdev, 1);
- fm_port = pnp_port_start(pdev, 2);
+ fm_port = pnp_port_start(pdev, 2) + 8;
#endif /* OPTi93X */
irq = pnp_irq(pdev, 0);
dma1 = pnp_dma(pdev, 0);
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
