At Wed, 5 Sep 2007 15:23:06 -0700 (PDT), Trent Piepho wrote: > > On Wed, 5 Sep 2007, Takashi Iwai wrote: > > At Tue, 4 Sep 2007 04:49:46 -0700 (PDT), > > Trent Piepho wrote: > > > > > > - BT_DEVICE(PCI_DEVICE_ID_BROOKTREE_878, 0x0070, 0x13eb, 32000), > > > + BT_DEVICE(_878, 0x0070, 0x13eb, SND_BT87X_BOARD_HAUPPAUGE878), > > > > It's a bad move. As Clemens pointed, it was in a similar expression > > in the earlier version, but we changed to the form with > > PCI_DEVICE_ID_ prefix *intentionally* after complains from kernel > > hackers (and that was reasonable). If the length of a line really > > matters, we can drop SND_BT87X_ prefix from the board enum items > > instead. > > This is what I've done. I think last time I sent the patch I accidently > sent an old version without this change. > > I also merged a few of the SND_BT87X boards with the same configuration. > Initially I though each board should have a unique entry in the > configuration list, but the fact is that there are only a couple different > configurations now, and probably won't be many more, if any. It makes more > sense to think of it as a "board type id" instead of "board id", since > there is several times more boards than there are board types. OK, then that's fine. I merged your patch to HG tree now. Thanks! Takashi _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
