Dnia 5-09-2007 o godz. 15:20 Takashi Iwai napisał(a): > At Wed, 05 Sep 2007 00:24:33 +0200, > Rene Herman wrote: > > > -#if 0 > > > - snd_printdd("WSS signature = 0x%x\n", tmp); > > > -#endif > > > > Please don't just kill debug code. It's very useful for the next person > > stepping in -- it's "functional commentary". > > Then let's get rid of "#if 0". snd_printdd() won't get compiled > unless CONFIG_SND_DEBUG_DETECT is set, so there is no reason to kill > twice. > I have thought the same this morning. Ok. Now I am confused. Should I fix the patch and post it or should I do nothing with the sgalaxy.c as it will be (hopefully) soon replaced by a new driver (Rene's)? Regards, Krzysztof ---------------------------------------------------- Walka jakiej nie widziałeś! KSW eliminacje, nie wszyscy przejdą cało! Zobacz na żywo we Wrocławiu już 15 września. Więcej -> http://klik.wp.pl/?adr=http%3A%2F%2Fadv.reklama.wp.pl%2Fas%2Fksweliminacje.html&sid=12 _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel