At Wed, 05 Sep 2007 00:41:25 +0200,
Rene Herman wrote:
>
> On 09/04/2007 11:53 PM, Krzysztof Helt wrote:
>
> > +static void snd_ad1848_ready(struct snd_ad1848 *chip)
>
> Same request for a name change -- "ready" sounds boolean to me...
Agreed. Also, the error output of timeout can be better in
snd_ad1848_ready().
> > -#if 0
> > - printk("codec out - reg 0x%x = 0x%x\n", chip->mce_bit | reg, value);
> > -#endif
>
> Grrrrrr.
Well, I think it's ok to remove such dead codes. If it's really
supposed to revive, they shouldn't be #if 0 but with other macros,
such as snd_printdd().
Takashi
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
