Re: [PATCH] sgalaxy: checkpatch fixes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 09/05/2007 06:47 AM, Krzysztof Helt wrote:

> I about acquring the SG Waverider card. I saw your driver and thought 
> about asking you to cooperate to merge you driver into the sgalaxy or
> polish the driver more. You are just one step before me.

Ah, recently grabbed a Waverider as well. I now have some 15 Sound Galaxy 
models I believe which is partly why testing them all is taking too 
much/long ;-)

Will make time now though.

> Yes, but as I am about merging your patch into the sgalaxy
> (my first idea).
> I want to avoid situation with patches being rejected due
>  to coding style problem in context lines.

Nah, really the only "important" thing is (while you're there) to do the "if 
((err = ))" breaking -- noone here is religious about the rest.

But, well, forgetting all about sgalaxy.c makes as much sense. The new 
driver already support more models anyway (the ones without EEPROMs).

Rene.
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux