Hah, um, ignore me. It seems that my c needs some work ;) In if(some_expression), I always though it is true if the expression is > 0, not != 0. If anything, that was a CodingStyle patch because it lets us see exactly what we're getting from request_irq but I can see that it is totally unnecessary :) > ----- Original Message ----- > From: "Ash Willis" <ashwillis@xxxxxxxxxxxxxx> > To: alsa-devel@xxxxxxxxxxxxxxxx > Subject: [PATCH] Fix request_irq error handling > Date: Sat, 14 Jul 2007 02:29:19 -0500 > > > request_irq returns 0 on success and a negative code on failure. > Many ALSA drivers incorrectly check for failure by testing for a > positive code instead of a negative one. > > Signed-Off-By: Ash Willis <ashwillis@xxxxxxxxxxxxxx> > > > -- > We've Got Your Name at http://www.mail.com! > Get a FREE E-mail Account Today - Choose From 100+ Domains > << request_irq_error_handling.patch >> > > _______________________________________________ > Alsa-devel mailing list > Alsa-devel@xxxxxxxxxxxxxxxx > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel > -- We've Got Your Name at http://www.mail.com! Get a FREE E-mail Account Today - Choose From 100+ Domains _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
