Re: [PATCH] Disable debugging output for the ALS300 driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



At Tue, 29 May 2007 09:09:39 -0500,
Ash Willis wrote:
> 
> > Also I changed "if ((err = ...))" to two individual lines, which is a
> > newer standard kernel coding style.
> > 
> 
> Yeah, I left that for now. I'll go through the tree and tidy up remaining
> occurences of this style when I have some time.

Note that I didn't rewrite the existing lines but just changes in the
patch.  It'll be appreciated if you send a patch to clean up these
things in your driver.

> It seems that when people add drivers to the tree, they generally copy
> already existing drivers. It doesn't make much sense to be copying code
> that doesn't fit CodingStyle.

Right.  A general clean up work is appreciated.


thanks,

Takashi
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux