Re: [PATCH] Add support for Cyrix/NatSemi Geode CS5530 (VSA1)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



At Thu, 24 May 2007 09:09:29 -0500,
Ash Willis wrote:
> 
> Takashi, here are my modified patches.
> One small one for alsa-driver.
> I took your advice and merged the rest into alsa-kernel.
> Everything should be in order this time.
> 
> Add support for Cyrix/NatSemi Geode SC5530 (VSA1)
> 
> Signed-off-by Ash Willis <ashwillis@xxxxxxxxxxxxxx>

Thanks.  One thing I overlooked at the previous review is the kconfig
dependency below:


> diff -r 45179b325c8e -r 0b0c03c6c6ca pci/Kconfig
> --- a/pci/Kconfig	Wed May 23 16:27:32 2007 +0200
> +++ b/pci/Kconfig	Thu May 24 20:58:27 2007 +0100
> @@ -214,6 +214,16 @@ config SND_CS46XX_NEW_DSP
>  	  Say Y here to use a new DSP image for SPDIF and dual codecs.
>  
>  	  This works better than the old code, so say Y.
> +
> +config SND_CS5530
> +	tristate "CS5530 Audio"
> +	depends on SND

The driver should also depend on ISA_DMA_API.  Look at SND_ALS4000
entry.  Otherwise it looks fine.


Takashi
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux