Re: [PATCH] Add support for gain in softvol plugin

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



At Thu, 10 May 2007 12:57:10 -0700,
Steve Longerbeam wrote:
> 
> Hi Takashi,
> 
> Thanks, that's much better. I tried doing that myself a while ago, but I 
> must have been doing something wrong because the capture device wasn't 
> being recognized. But your version works.
> 
> Version 4 of the patch is attached. It's much better, only two modified 
> files: pcm_softvol.c and HDA-Intel.conf.
> 
> I also reduced the gain range, it's now -30 to +30 dB.

I'm afraid that this choice would be bad for the current TLV
representation.  The default resolution is 256, so -30/30 dB range
doesn't match to this resolution.  We should change either resolution
(e.g. 120, corresponding to 0.5dB step), or the range.

Otherwise it looks fine to me.


Thanks,

Takashi
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux