At Mon, 16 Apr 2007 17:07:24 +0100, Liam Girdwood wrote: > > On Mon, 2007-04-16 at 17:03 +0200, Takashi Iwai wrote: > > At Mon, 16 Apr 2007 15:46:05 +0100, > > Liam Girdwood wrote: > > > > > > This patch series adds support for the WM8753 codec as found on the > > > OpenMoko Neo 1973 (other Neo 1973 and Samsung S3C24xx patches to follow > > > today) as well other new devices. > > > > > > Features:- > > > > > > o HiFi and Voice DAI supported (inc runtime switching of DAI mode) > > > o DAPM > > > o All mixers > > > o PLL calculator > > > o 16,20 and 24bit samples. > > > o WM8753 I2C ID added to include/linux/i2c-id.h > > > > > > Signed-off-by: Harald Welte <laforge@xxxxxxxxxxxx> > > > Signed-off-by: Graeme Gregory <gg@xxxxxxxxxxxxxxxxxxxxxxxxxxx> > > > Signed-off-by: Seth Forshee <seth.forshee@xxxxxxxxx> > > > Signed-off-by: Liam Girdwood <lg@xxxxxxxxxxxxxxxxxxxxxxxxxxx> > > > > Am I correct to understand that Harald is the patch author? > > > > No, I'm the main author and have received patches from Harald, Graeme > and Seth. Should the ordering be different in this case ? The first peson is usually the author, and others approve the patch. If not, put 'From: xxx' explicitly before Sign-off to indicate the author. > > > +static int caps_charge = 2000; > > > +module_param(caps_charge, int, 0); > > > > Don't want to export to sysfs? > > We unfortunately can't with this variable as it's used in init to > prepare the codec. Yes, but I thought passing 0 prohibits even seeing the value. It's no big issue anyway. Takashi _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
