At Mon, 09 Apr 2007 14:53:31 +0200,
Dominique Dumont wrote:
>
> Takashi Iwai <tiwai@xxxxxxx> writes:
>
> > OK, now it's on HG tree.
>
> Could you also include the following patch that trace verbs sent to
> the codec and the responses?
>
> These traces were invaluable to figure out what was going on when I
> hunted for the spdif bug. I believe it will also be valuable if people
> have to look for other hda bugs.
I think snd_printdd() isn't appropriate for this because you cannot
choose it at runtime but only at build time. My preference is to add
a debug module option (with ifdef CONFIG_SND_DEBUG) and check the
option value there.
thanks,
Takashi
>
> Cheers
>
> Signed-off by: Dominique Dumont <domi.dumont@xxxxxxx>
>
> diff -r 42321871a7dc pci/hda/hda_codec.c
> --- a/pci/hda/hda_codec.c Thu Apr 05 17:08:57 2007 +0200
> +++ b/pci/hda/hda_codec.c Mon Apr 09 14:17:55 2007 +0200
> @@ -87,6 +87,9 @@ unsigned int snd_hda_codec_read(struct h
> else
> res = (unsigned int)-1;
> mutex_unlock(&codec->bus->cmd_mutex);
> + snd_printdd(KERN_INFO
> + "hda_intel codec read: nid %x direct %x verb %x parm %x -> %x\n",
> + nid, direct, verb, parm, res) ;
> return res;
> }
>
> @@ -108,6 +111,9 @@ int snd_hda_codec_write(struct hda_codec
> unsigned int verb, unsigned int parm)
> {
> int err;
> + snd_printdd(KERN_INFO
> + "hda_intel codec write: nid %x direct %x verb %x parm %x\n",
> + nid, direct, verb, parm) ;
> mutex_lock(&codec->bus->cmd_mutex);
> err = codec->bus->ops.command(codec, nid, direct, verb, parm);
> mutex_unlock(&codec->bus->cmd_mutex);
>
>
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
