At Thu, 15 Mar 2007 12:56:58 +0800, Nicolas Boichat wrote: > > Sorry the patch got wrapped....... > > Nicolas Boichat wrote: > > Hello, > > > > Rafael Espíndola wrote: > > > >>> The patch is based on reports by Rafael Espindola (Cc'ed). > >>> Rafael, which model do you have exactl? > >>> > >> A core 2 duo (second generation). > >> > > > > Ok I added a comment in the code about this. > > > > > >>> IMO, it's bad to rename the existing model name as it has been already > >>> used in ALSA tree. So please simply add a new model name for your > >>> device, e.g. macbook-pro-v1. > >>> > > > > Fixed. > > > > > >>> Otherwise the patch looks good to me. > >>> > >> Just nitpicking: Do we use upper or lower case in hexadecimal number? > >> > > > > Ok ok... Lower case .-) The other pins are lower case... > > > > New patch attached. > > > Fix audio on Macbook Pro 1st generation. > > Signed-off-by: Nicolas Boichat <nicolas@xxxxxxxxxx> Thanks, applied to HG tree now. Takashi ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.sourceforge.net/lists/listinfo/alsa-devel
