At Mon, 19 Feb 2007 13:53:09 +0200,
Constantine Gavrilov wrote:
>
> Takashi Iwai wrote:
> > At Sun, 18 Feb 2007 13:58:03 +0200,
> > Constantine Gavrilov wrote:
> >
> >> OK. Attached. Not changed in the bug tracking system as I could not find a way to
> >> remove original patch.
> >>
> >
> > That doesn't matter.
> >
> >
> >
> >> --- alsa/alsa-oss.c.orig 2007-02-18 13:29:08.000000000 +0200
> >> +++ alsa/alsa-oss.c 2007-02-18 13:37:45.000000000 +0200
> >>
> > (snip)
> >
> >> +#define DECL_OPEN(name, callback) \
> >> +int name(const char *file, int oflag, ...) \
> >> +{ \
> >> + va_list args; \
> >> + mode_t mode = 0; \
> >> + int fd; \
> >> + if (!initialized) \
> >> + initialize(); \
> >> + if (oflag & O_CREAT) { \
> >> + va_start(args, oflag); \
> >> + mode = va_arg(args, mode_t); \
> >> + va_end(args); \
> >> + } \
> >> + if (is_dsp_device(file)) \
> >> + dsp_open_helper(file, oflag); \
> >> + else if (is_mixer_device(file)) \
> >> + mixer_open_helper(file, oflag); \
> >>
> >
> > Missing returns (or fd = ) here...
> >
> >
> > Takashi
> >
> >
> You are right. Missing fd = coming from macro -> function conversion.
> Fixed patch attached.
Thanks, applied to HG tree now.
Takashi
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.sourceforge.net/lists/listinfo/alsa-devel
