At Mon, 5 Feb 2007 19:16:35 +0100,
Rolf Stefan Wilke wrote:
>
> The following patch fixes bug #2308 [no sound on front channel for
> emu10k1 - sigmatel STAC9758]; at least for me. Thanks to Raymond at bugtrack!
>
> Stefan
>
> --- alsa-driver-1.0.14rc2.orig/alsa-kernel/pci/emu10k1/emumixer.c
> 2007-01-15 14:25:27.000000000 +0100
> +++ alsa-driver-1.0.14rc2/alsa-kernel/pci/emu10k1/emumixer.c 2007-02-05
> 19:10:48.000000000 +0100
> @@ -1582,6 +1582,7 @@
> if (emu->ac97->id == AC97_ID_STAC9758) {
> emu->rear_ac97 = 1;
> snd_emu10k1_ptr_write(emu, AC97SLOT, 0,
> AC97SLOT_CNTR|AC97SLOT_LFE|AC97SLOT_REAR_LEFT|AC97SLOT_REAR_RIGHT);
> + snd_ac97_write_cache(emu->ac97, 0x04, 0x0202);
Replace 0x04 with AC97_HEADPHONE, which explains better.
Also, your MUA doesn't work with the embedded patch, and it cannot be
applied cleanly. Use attachments in such a case.
Otherwise the patch looks good to me. Could you provide a proper
changelog (the subject and the description of the patch) and a
sign-off (Signed-off-by: XXX <xxx@xxx>) for merging to the upstream,
too?
Thanks,
Takashi
-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier.
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.sourceforge.net/lists/listinfo/alsa-devel
