At Fri, 02 Feb 2007 18:03:19 +0000,
Liam Girdwood wrote:
>
> diff -r 0f9c7c3b7657 soc/s3c24xx/s3c24xx-i2s.c
> --- /dev/null Thu Jan 01 00:00:00 1970 +0000
> +++ b/soc/s3c24xx/s3c24xx-i2s.c Wed Jan 31 16:43:17 2007 +0000
(snip)
> +static void s3c24xx_snd_txctrl(int on)
> +{
> + unsigned long iisfcon;
> + unsigned long iiscon;
> + unsigned long iismod;
Should be u32. unsigned long could be 64bit.
> +static void s3c24xx_snd_rxctrl(int on)
> +{
> + unsigned long iisfcon;
> + unsigned long iiscon;
> + unsigned long iismod;
Ditto.
> +static int s3c24xx_snd_lrsync()
> +{
> + unsigned long iiscon;
Ditto.
> + int timeout = 10000;
> +
> + DBG("Entered %s\n", __FUNCTION__);
> +
> + while (1) {
> + iiscon = readl(s3c24xx_i2s.regs + S3C2410_IISCON);
> + if (iiscon & S3C2410_IISCON_LRINDEX)
> + break;
> +
> + if (--timeout < 0)
> + return -ETIMEDOUT;
> + }
How tolerant should it be? This style of busy loop depends on the
machine speed and isn't reliable.
> +static int s3c24xx_i2s_trigger(struct snd_pcm_substream *substream, int cmd)
> +{
> + int ret = 0;
> + unsigned long flags;
Unused variable?
> +static void s3c24xx_i2s_shutdown(struct snd_pcm_substream *substream)
> +{
> + unsigned long iismod, iiscon, iisfcon;
Unused variables.
> +#ifdef CONFIG_PM
> +static int s3c24xx_i2s_suspend(struct platform_device *dev,
> + struct snd_soc_cpu_dai *dai)
> +{
> +}
> +
> +static int s3c24xx_i2s_resume(struct platform_device *pdev,
> + struct snd_soc_cpu_dai *dai)
> +{
> +}
No return values?
> +/*
> + * Set S3C24xx Clock source
> + */
> +static int s3c24xx_i2s_set_sysclk(struct snd_soc_cpu_dai *cpu_dai,
> + int clk_id, unsigned int freq, int dir)
> +{
> + unsigned long iismod = readl(s3c24xx_i2s.regs + S3C2410_IISMOD);
Use u32.
> +/*
> + * Set S3C24xx Clock dividers
> + */
> +static int s3c24xx_i2s_set_clkdiv(struct snd_soc_cpu_dai *cpu_dai,
> + int div_id, int div)
> +{
> + unsigned long reg;
Ditto.
Takashi
-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier.
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.sourceforge.net/lists/listinfo/alsa-devel
