At Thu, 25 Jan 2007 10:56:41 +0100, Matthias Koenig wrote: > > Takashi Iwai <tiwai@xxxxxxx> writes: > >> > Also, added cpu_relax() in busy loops, and fixed unneeded > >> > initialization of variables. > >> > >> Ok, thanks > >> > >> > The code is now committed to ALSA HG tree. Please give it a try. > >> > >> Ah, I just tested and found that the rawmidi open/close callbacks > >> have to be defined and cannot be NULL. So the driver as it is > >> will oops if device will be opened. > >> Fixed this, now tested with amidi input/output on all ports works > >> fine. Patch is below. > > > > Thanks, applied now. > > > >> > BTW, if the driver works for you, we can move this to alsa-kernel tree > >> > so that it's merged to the upstream kernel... > >> > >> Great, yes I think it can then be moved to alsa-kernel tree. > > > > OK, I'll work on this tomorrow. > > Ok, I still found another minor issue. Probably we do not need > irqsave/irqrestore for the spinlock calls in the interrupt handler. > > Matthias > > Signed-off-by: Matthias Koenig <mkoenig@xxxxxxx> > ===================================================================== > Summary: portman2x4 - do not use irqsave/irqrestore in IRQ handler > > Replace spin_lock_irqsave/spin_unlock_irqrestore with > spin_lock/spin_unlock in IRQ handler. Thanks, applied to HG tree now. Takashi ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.sourceforge.net/lists/listinfo/alsa-devel
