Re: A FIX FOR alsa-lib emu10k1.h (IT FIXES ld10k1)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



At Fri, 19 Jan 2007 01:17:38 +0000 (UTC),
Tim wrote:
> 
> On Thursday 18 January 2007 6:08 am, you wrote:
> > At Wed, 17 Jan 2007 13:35:10 +0100,
> > > terminator356 -> users.sourceforge.net wrote:
> > > > Hi, ld10k1 doesn't work, crashes. Lots of people saying it.
> > > > In the alsa-kernel/include emu10k1.h,
> > > > 	union {
> Sorry that should be alsa-kernel/include/sound/emu10k1.h

No, it's really alsa-kernel/include/emu10k1.h.  It's a fix for the
driver, not the library.

> > > Well, this is an ABI breakage by introducing the TLV support.
> What is ABI? "Always Broken Interface"? He he...

Ask google :)

> > The patch below changes the driver to accept the old ABI as default,
> > then switch to the new ABI if EMU10K1_PVERSION ioctl is called.
> > Could you give it a try?  If it works, I'll post a patch to ld10k1 to
> > switch to the new ABI.
> > Takashi
> >
> > diff -r beb52b12c43f include/emu10k1.h
> > --- a/include/emu10k1.h	Tue Jan 16 17:49:21 2007 +0100
> > +++ b/include/emu10k1.h	Thu Jan 18 12:04:51 2007 +0100
> (Should be include/sound/emu10k1.h)
> 
> > @@ -1449,6 +1449,7 @@ struct snd_emu10k1 {
> >  	unsigned int tos_link: 1,		/* tos link detected */
> >  		rear_ac97: 1,			/* rear channels are on AC'97 
> */
> >  		enable_ir: 1;
> > +	unsigned int support_tlv :1;
> 
> This is what I get, what am I doing wrong?:
> [me@localhost sound]# patch -p1 emu10k1.h alsa-driver-tiwai-emu10k1-h-patch
> patching file emu10k1.h
> patch: **** malformed patch at line 5: unsigned int tos_link: 1,/* tos link 
>            detected */

You mailer seems not able to handle the embedded patch...
I put the patch below as an attachment.


Takashi

Attachment: emu10k1-ld10k1-compat-fix.diff
Description: Binary data

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.sourceforge.net/lists/listinfo/alsa-devel

[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux