On Fri, Jan 12, 2007 at 05:21:17PM +0100, Takashi Iwai wrote: > Thanks for the patch (and sorry for the delayed review). The code > looks good now. > > One remaining concern is how we can integrate this with the existing > ac97_quirk stuff. For example, if a quirk tweaking the master > volume/switch is applied, this may conflict with the ganged volumes. > In other words, the ganged controls should be applied _after_ the > quirks. > > Then I'm considering whether it might be rather easier to implement > the virtual master element from the beginning. Basically, the virtual > master is required for almost all codec chips with the surround > support, not only for VT161x. So, featuring this as default isn't bad > in the end. > > Oh, also, TLV support is another thing to do. > This should be relatively easy, though. I agree on both points, but I don't think I can do it myself without breaking lots of other cards. At this point, maybe someone else is interested in picking up this patch? Oh, and in that case, I will post the minimal bits for VT1617A surround separately. -- Daniel Jacobowitz CodeSourcery ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.sourceforge.net/lists/listinfo/alsa-devel
