Takashi Iwai wrote: > At Mon, 08 Jan 2007 15:15:45 +0100, > Benoit Fouet wrote: > >> reading it quickly, i found one case reaching this point: >> around line 120 in timer.c: >> err = snd_config_search_definition(timer_root, "timer_type", str, >> &type_conf); >> if (err >= 0) { >> if (snd_config_get_type(type_conf) != SND_CONFIG_TYPE_COMPOUND) { >> SNDERR("Invalid type for TIMER type %s definition", str); >> goto _err; >> } >> > > Ah, in that case, we should set err in a real error code such as > -EINVAL. > > yes, could be a good idea... in that case, my previous patch is useless, even if the warning will surely still be there. Ben ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.sourceforge.net/lists/listinfo/alsa-devel