At Mon, 8 Jan 2007 15:13:00 +0100,
Lennert Buytenhek wrote:
>
> > > +#ifdef CONFIG_PM
> > > +static int ep93xx_ac97_suspend(struct platform_device *dev, pm_message_t state)
> > > +{
> > > + return 0;
> >
> > Hm, don't you need any suspend action for PCM and AC97 registers?
>
> At the least, I suppose we should deactivate the AC link, and perhaps
> we can also gate the DMA channel clock. I'll implement this.
OK, then I suppose that the PM isn't really tested with your driver?
> > > +static u64 ep93xx_pcm_dmamask = 0xffffffff;
> >
> > Use DMA_32BIT_MASK.
>
> OK. Note that pxa2xx-pcm has the same construct.
>
>
> > > + pcm->private_data = client;
> > > + pcm->private_free = ep93xx_pcm_free_dma_buffers;
> > > +
> > > + if (!card->dev->dma_mask)
> > > + card->dev->dma_mask = &ep93xx_pcm_dmamask;
> > > + if (!card->dev->coherent_dma_mask)
> > > + card->dev->coherent_dma_mask = 0xffffffff;
> >
> > Doesn't dma_set_mask() work?
>
> Again, this was just copied from pxa2xx-pcm. I'll have a look.
Care to create a fix patch for pxa2xx-pcm, too?
> > > +EXPORT_SYMBOL(ep93xx_pcm_new);
> > > +
> > > +MODULE_AUTHOR("Lennert Buytenhek <buytenh@xxxxxxxxxxxxxx>");
> > > +MODULE_DESCRIPTION("EP93xx ALSA PCM interface");
> > > +MODULE_LICENSE("GPL");
> >
> > Could ep93xx-pcm be merged to ep93xx-ac97 as a single module?
> > Since you have only one interface, it doesn't make much sense to split
> > to two modules. With a single module, you can avoid unnecessary
> > exported symbols.
>
> The ep93xx CPU also has I2S/SSP, which I haven't yet written a driver
> for -- but someone else started work on an I2S driver:
>
> http://www.freelists.org/archives/linux-cirrus/01-2007/msg00018.html
Fine, then let's keep them as individual modules.
thanks,
Takashi
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.sourceforge.net/lists/listinfo/alsa-devel
