Re: [alsa-cvslog] alsa-lib: Implements support for capture/playback enums.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jaroslav Kysela wrote:
> On Fri, 13 Oct 2006, James Courtier-Dutton wrote:
> 
>> +	{" Playback Enum", CTL_PLAYBACK_ENUM},
>> +	{" Capture Enum", CTL_CAPTURE_ENUM},
>> +	{" Enum", CTL_GLOBAL_ENUM},
> 
> I don't like this. We already know, that it's the enum type, so it's not 
> required to put this type to control id name again.
> 
> Could you just check, if control id name ends with " Capture" or 
> " Playback" words and set CTL_XXXX_ENUM according that?
> 

Is did it that way, for consistency.
If you look at the naming of switches, volumes, I just used the same 
pattern for enums.

James


-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.sourceforge.net/lists/listinfo/alsa-devel

[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux