On Thu, 5 Oct 2006, Jaroslav Kysela wrote:
> Unfortunately, I do not think that it's a proper solution. I think that
> platform device layer should play more nicely and if probe() fails for a
> reason and if platform_device_register_simple() does not set IS_ERR(),
> then platform_device_unregister() must be callable to free all
> resources.
I agree.
> I would reject this patch and fix drivers/base/bus.c. The problematic
> change is in commit f2eaae197f4590c4d96f31b09b0ee9067421a95c and this
> patch will probably fix it:
> [PATCH] drivers/base - check if device is registered before removal
> Without this fix platform_device_unregister() might oops.
> Signed-off-by: Jaroslav Kysela <perex@xxxxxxx>
> diff --git a/drivers/base/bus.c b/drivers/base/bus.c
> index 12173d1..daa2390 100644
> --- a/drivers/base/bus.c
> +++ b/drivers/base/bus.c
> @@ -428,8 +428,10 @@ void bus_remove_device(struct device * d
> sysfs_remove_link(&dev->kobj, "bus");
> sysfs_remove_link(&dev->bus->devices.kobj, dev->bus_id);
> device_remove_attrs(dev->bus, dev);
> - dev->is_registered = 0;
> - klist_del(&dev->knode_bus);
> + if (dev->is_registered) {
> + dev->is_registered = 0;
> + klist_del(&dev->knode_bus);
> + }
> pr_debug("bus %s: remove device %s\n", dev->bus->name, dev->bus_id);
> device_release_driver(dev);
> put_bus(dev->bus);
Yes, it (among other things) fixes the panic in MPU401 initialization.
Acked-by: Jiri Kosina <jikos@xxxxxxxx>
--
Jiri Kosina
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys -- and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.sourceforge.net/lists/listinfo/alsa-devel
