At Mon, 02 Oct 2006 17:15:26 +0100,Liam Girdwood wrote:> > Index: alsa-kernel/soc/codecs/wm8731.c> +static const char* wm8731_input_select[] = {"Line In", "Mic"};> +static const char* wm8731_deemph[] = {"None", "32Khz", "44.1Khz", "48Khz"};
Pointers in C-style, please.
> + /* set master/slave audio interface */> + switch(rtd->codec_dai->dai_runtime.fmt & SND_SOC_DAIFMT_CLOCK_MASK) {
A space after switch is preferred.
> +#ifdef CONFIG_I2C
It's not always builtin. It could be CONFIG_I2C_MODULE.
Also, I got compile warnings when I2C_MODULE!=y.
In file included from /export/alsa/work/alsa-driver/soc/codecs/wm8731.c:2: wm8731.c: In function ʽwm8731_probeʼ: wm8731.c:730: warning: unused variable ʽsetupʼ wm8731.c: At top level: wm8731.c:576: warning: ʽwm8731_initʼ defined but not used
Ditto for wm8750.c.
Takashi
-------------------------------------------------------------------------Take Surveys. Earn Cash. Influence the Future of ITJoin SourceForge.net's Techsay panel and you'll get the chance to share youropinions on IT & business topics through brief surveys -- and earn cashhttp://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV_______________________________________________Alsa-devel mailing listAlsa-devel@xxxxxxxxxxxxxxxxxxxxxxxxxx://lists.sourceforge.net/lists/listinfo/alsa-devel
