At Wed, 4 Oct 2006 12:18:47 +0100,
Jochen Voss wrote:
>
> Enable capture from line-in and CD on the Revolution 5.1 card.
>
> This patch adds support for switching between the 5 input channels of
> the AK5365 ADC and modifies the Revolution 5.1 driver to make use of
> this facility. Previously the capture channel was fixed to channel 0
> (microphone on the Revolution 5.1 card).
>
> Signed-off-by: Jochen Voss <voss@xxxxxxxxxx>
Thanks, both patches are applied to HG tree now.
> > > if (ak->type == SND_AK5365 && (idx % 2) == 0) {
> > > if (! ak->adc_info ||
> > > - ! ak->adc_info[mixer_ch].switch_name)
> > > + ! ak->adc_info[mixer_ch].switch_name) {
> > > knew.name = "Capture Switch";
> > > - else
> > > + knew.index = mixer_ch + ak->idx_offset * 2;
> > > + } else {
> > > knew.name = ak->adc_info[mixer_ch].switch_name;
> > > + }
> >
> > Don't put braces around a single-line if.
>
> I found it ugly to have braces around the two line if branch but no
> braces around the one line else branch. But I fixed it anyway.
Yeah, some styles are not my personal preference, too, but a rule is a
rule. The only reason that it exists is to follow it :)
Takashi
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys -- and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.sourceforge.net/lists/listinfo/alsa-devel
