At Thu, 7 Sep 2006 12:29:54 +0200, Rafael J. Wysocki wrote: > > On Thursday, 7 September 2006 11:20, Takashi Iwai wrote: > > At Wed, 6 Sep 2006 22:59:53 +0200, > > Rafael J. Wysocki wrote: > > > > > > Hi, > > > > > > I get the appended BUG when I try to rmmod snd_hda_intel on 2.6.18-rc5-mm1 > > > (the box is an HPC nx6325). > > > > > > The driver also breaks the suspend to disk (causes an oops to appear during > > > the suspend phase, but I haven't been able to catch it yet). > > > > Could you try the patch below? It's pending on my local tree for > > testing... Also, you can use disable_msi=1 option to avoid MSI. > > The patch fixes the rmmod issue. > > Also setting disable_msi=1 fixes the suspend issue. > > If the MSI is not disabled, the suspend fails with an oops (on an attempt to > access disk after the resume-during-suspend), but this will hopefully get > fixed with the new MSI code. The PM problem might be fixed by the patch below. Give it a try. Takashi diff -r 4f27a5064cda sound/pci/hda/hda_intel.c --- a/sound/pci/hda/hda_intel.c Thu Sep 07 12:40:00 2006 +0200 +++ b/sound/pci/hda/hda_intel.c Thu Sep 07 15:20:56 2006 +0200 @@ -1375,6 +1375,10 @@ static int azx_suspend(struct pci_dev *p snd_pcm_suspend_all(chip->pcm[i]); snd_hda_suspend(chip->bus, state); azx_free_cmd_io(chip); + if (chip->irq >= 0) + free_irq(chip->irq, chip); + if (!disable_msi) + pci_disable_msi(chip->pci); pci_disable_device(pci); pci_save_state(pci); return 0; @@ -1387,6 +1391,12 @@ static int azx_resume(struct pci_dev *pc pci_restore_state(pci); pci_enable_device(pci); + if (!disable_msi) + pci_enable_msi(pci); + /* FIXME: need proper error handling */ + request_irq(pci->irq, azx_interrupt, IRQF_DISABLED|IRQF_SHARED, + "HDA Intel", chip); + chip->irq = pci->irq; pci_set_master(pci); azx_init_chip(chip); snd_hda_resume(chip->bus); ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.sourceforge.net/lists/listinfo/alsa-devel
