On Sun, 3 Sep 2006 01:15:10 +0200 Pavel Machek wrote: > Hi! > > > > Hm, it looks rather like a personal preference. > > > IMHO, it's harder to read without space... > > > > We have been tending toward not using space in cases like this > > (in my unscientific memory-based survey). > > > > So, just this morning I have seen questions and opinions about > > the following that could (or could not) use more documentation > > or codification and I'm sure that we could easily find more, > > but do we want to codify Everything?? > > > > > > 1. Kconfig help text should be indented (it's not indented in the > > GFS2 patches) > > > > 2. if (!condition1) /* no space between ! and condition1 */ > > > > 3. don't use C99-style // comments > > > > 4. unsigned int bitfield :<nr_bits>; > > Looks reasonable to me. Will you do the patch or should I ? Please (you) go ahead with it. Thanks, --- ~Randy ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.sourceforge.net/lists/listinfo/alsa-devel