At Wed, 23 Aug 2006 18:17:43 +0400, Andrew L. Neporada wrote: > > Takashi Iwai wrote: > > At Wed, 23 Aug 2006 16:29:04 +0400, > > Andrew L. Neporada wrote: > > > > > > Hi! > > > > > > It seems that I've fixed mic problem by adjusting VRef setting on > > > Pin Complex node #0x14. > > > > Good catch. > > Could you try the patch below instead? > > > > It works also. > > But I am a bit unsure about > > case AC_JACK_MIC_IN: > + *pinctl |= AC_PINCTL_VREF_80; > > Shouldn't this be conditional and based on node->pin_caps VREF caps? Right, it's safer to check the pin caps like: if (node->pin_caps & (AC_PINCAP_VREF_80 << AC_PINCAP_VREF_SHIFT)) *pinctl |= AC_PINCTL_VREF_80; > Maybe we need patch_connexant.c ? Yes, it'll be more flexible for changing the code. Takashi ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.sourceforge.net/lists/listinfo/alsa-devel
