Re: [PATCH] complete the AK5365 support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Takashi,

On Wed, Aug 09, 2006 at 02:37:06PM +0200, Takashi Iwai wrote:
> One missing thing I found is that AK5365 isn't in snd_akm4xxx_init().
> When CONFIG_SND_DEBUG=y, this will cause an error message (in
> default: case).  Could you add a proper init sequence there?

Ok, I am back now.  I see that in the mean time somebody added the
following:

diff -ur alsa-driver-1.0.12rc2/alsa-kernel/i2c/other/ak4xxx-adda.c alsa-driver-1.0.12rc3/alsa-kernel/i2c/other/ak4xxx-adda.c
--- alsa-driver-1.0.12rc2/alsa-kernel/i2c/other/ak4xxx-adda.c   2006-08-08 23:53:09.000000000 +0100
+++ alsa-driver-1.0.12rc3/alsa-kernel/i2c/other/ak4xxx-adda.c   2006-08-14 11:55:24.000000000 +0100
@@ -137,6 +137,8 @@
        case SND_AK4381:
                ak4381_reset(ak, state);
                break;
+       default:
+               break;
        }
 }
 

From the data sheet of the chip it seems to me that there is no way to
initialise the chip via register settings.  Should I add a procedure which
writes the default values from the data sheet to all registers instead?
Or is the current way (doing nothing) ok?

All the best,
Jochen
-- 
http://seehuhn.de/

Attachment: signature.asc
Description: Digital signature

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.sourceforge.net/lists/listinfo/alsa-devel

[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux