At Sun, 13 Aug 2006 02:01:53 -0700, Richard Fish wrote: > > Hi all, > > I noticed a problem with S3 resume and my STAC9200 Intel HDA chip. If > I restart alsa after resuming, the pin configurations are wrong. My > specific system isn't recognized, so it ends up using the BIOS > configuration, but the BIOS doesn't fix up the config registers on > resume. The debug messages with --with-debug=detect after boot are: > > .../patch_sigmatel.c:1279: hda_codec: Unknown model for STAC9200, > using BIOS defaults > .../hda_codec.c:2150: autoconfig: line_outs=0 (0x0/0x0/0x0/0x0/0x0) > .../hda_codec.c:2154: speaker_outs=2 (0xe/0x11/0x0/0x0/0x0) > .../hda_codec.c:2156: hp=0xd, dig_out=0x9, din_in=0x0 > .../hda_codec.c:2164: inputs: mic=0x10, fmic=0x0, line=0x0, > fline=0x0, cd=0x0, aux=0x0 > > While reloading after an S3 resume produces: > > .../patch_sigmatel.c:1279: hda_codec: Unknown model for STAC9200, > using BIOS defaults > .../hda_codec.c:2150: autoconfig: line_outs=1 (0xe/0x0/0x0/0x0/0x0) > .../hda_codec.c:2154: speaker_outs=0 (0x0/0x0/0x0/0x0/0x0) > .../hda_codec.c:2156: hp=0xd, dig_out=0x9, din_in=0x8 > .../hda_codec.c:2164: inputs: mic=0x0, fmic=0x10, line=0xf, > fline=0x0, cd=0x12, aux=0x0 > > Note that I am not talking about unloading the drivers before suspend, > and reloading them afterwards...there is really nothing that can be > done for that case obviously. I'm just looking to be able to do an > "alsasound restart" or driver update without having to reboot. > > So, my proposed and attached patch stores off the BIOS configuration, > and restores it on resume. Please review and comment. One thing it > does that may not be correct is that it uses the STAC_REF slot in the > tables to store the BIOS configuration. If this is a problem, it > should be easy enough to just add a STAC_BIOS slot to the tables. Yes, it's better to avoid such an overwrite of a static array since we may have multiple same codecs and the saved configurations may collide. I vote for making pin_configs either a fixed-size or a kmalloced array in the spec struct, and copying the pin table entries to there. Care to rewrite the patch in that manner, and provide a proper changelog and a signed-off-by line? Thanks, Takashi ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.sourceforge.net/lists/listinfo/alsa-devel
