At Wed, 09 Aug 2006 11:58:22 +0200, Johannes Berg wrote: > > Takashi Iwai wrote: > >> --- aoa/Kconfig~ 2006-08-08 16:02:30.000000000 -0400 > >> +++ aoa/Kconfig 2006-08-08 16:03:26.000000000 -0400 > >> @@ -5,6 +5,7 @@ > >> tristate "Apple Onboard Audio driver" > >> depends on SND > >> select SND_PCM > >> + select I2C > >> ---help--- > >> This option enables the new driver for the various > >> Apple Onboard Audio components. > >> > > > > Maybe better to put it in aoa/codecs/Kconfig. > > The requirement of i2c is not in the core part of aoa driver but in > > the codec support codes. > > > Yes, each codec except for toonie should select I2C. Looks like I missed > that, sorry. > > However, I was recently told that the expected behaviour with I2C (in a > thread discussing the motion sensor) that I2C should be depended upon, > not selected. I very much disagree (*), however, and would like to see a > select here. Hm, actually, Kconfig of snd-powermac uses depend I2C. I'm also in favor of select. That's why I asked about I2C_POWERMAC. > Unfortunately, I started new work in Nürnberg, don't have any internet > at home right now and am not supposed to bring my own laptop to work. > Would someone else create the required patch? The patch is below. It selects only I2C right now, though. Olaf, could you check whether it works? > > Should I2C_POWERMANC be selected, too? > It makes sense since the aoa driver is specific to machines that have > the i2c powermac bus, but I'm ambivalent about it. Though, does the G5 > require I2C_POWERMAC? I'm not completely sure about that. Someone who owned G5 must know... Takashi diff -r 5b67bba2d36f aoa/codecs/Kconfig --- a/aoa/codecs/Kconfig Tue Aug 08 21:13:42 2006 +0200 +++ b/aoa/codecs/Kconfig Wed Aug 09 12:10:43 2006 +0200 @@ -1,6 +1,7 @@ config SND_AOA_ONYX config SND_AOA_ONYX tristate "support Onyx chip" depends on SND_AOA + select I2C ---help--- This option enables support for the Onyx (pcm3052) codec chip found in the latest Apple machines @@ -18,6 +19,7 @@ config SND_AOA_TAS config SND_AOA_TAS tristate "support TAS chips" depends on SND_AOA + select I2C ---help--- This option enables support for the tas chips found in a lot of Apple Machines, especially ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.sourceforge.net/lists/listinfo/alsa-devel
