Re: [PATCH] ppc-beep - handle errors from input_register_device()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



At Wed, 2 Aug 2006 19:57:06 -0400,
Dmitry Torokhov wrote:
> 
> On Wednesday 02 August 2006 12:18, Takashi Iwai wrote:
> > BTW, does one need to input_free_device() after
> > input_unregister_device()?
> > 
> 
> No, input_free_device() must not be called after input_unregister_device()
> because the input_unregister_device() frees memory if it was the last
> reference.

Thanks, that I supposed, too.

> That's why I like to have input_register_device last.
> To keep error path tidy you may either grab and extra reference via
> input_get_device() or just set input_dev to NULL - input_free_device
> handles NULLs just fine.

OK, I committed your patch together with other fixes to ALSA tree.

Thanks!


Takashi

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys -- and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.sourceforge.net/lists/listinfo/alsa-devel

[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux