At Fri, 28 Jul 2006 21:17:07 +0200,
Ondrej Zary wrote:
>
> On Friday 28 July 2006 12:32, Takashi Iwai wrote:
> > At Thu, 27 Jul 2006 22:00:18 +0200,
> >
> > Ondrej Zary wrote:
> > > On Thursday 27 July 2006 16:33, Takashi Iwai wrote:
> > > > At Sun, 23 Jul 2006 14:21:12 +0200,
> > > >
> > > > Ondrej Zary wrote:
> > > > > Hello,
> > > > > I have DTK notebook with integrated ESS ES1869 sound. The problem is
> > > > > that PnP does not work with ALSA driver and I have to use isaspnp=0
> > > > > parameter. The card probably does not have its own EEPROM and its 3
> > > > > IDs are inserted into system BIOS (as it's not found by ISA PNP but
> > > > > found by PNP BIOS). lspnp shows:
> > > > > [...]
> > > > > 00:18 ESS0006 (unknown)
> > > > > 00:19 ESS001 (unknown)
> > > > > 00:1a ESS1869 (unknown)
> > > > >
> > > > > I think that the problem is caused by es18xx.c which uses
> > > > > pnp_register_card_driver() and other pnp_card things which probably
> > > > > do not work when the PnP device does not look like ISA card but like
> > > > > 3 PnP devices.
> > > >
> > > > Right, only a few drivers support the PnP BIOS (non ISA PnP).
> > > > Actually, it shouldn't be too hard to add that feature. For example,
> > > > see opl3sa2.c. There are opl3sa2_pnpc_driver and opl3sa2_pnp_driver.
> > > > The latter is for PnP BIOS.
> > >
> > > Thanks for hint. I looked at opl3sa2.c and cs4236.c and added PnP BIOS
> > > support to es18xx.c. It works for me. Hopefully I didn't break ISA PnP
> > > support as I don't have hardware to test that (I had ES1868 card but gave
> > > it to friend some time ago).
> >
> > It shouldn't break since you check isapnp availability in
> > snd_audiodrive_pnp_detect().
> >
> > One thing I noticed:
> > > @@ -2404,9 +2497,12 @@
> > > }
> > >
> > > #ifdef CONFIG_PNP
> > > + err = pnp_register_driver(&es18xx_pnp_driver);
> > > + if (!err)
> > > + pnp_registered = 1;
> > > err = pnp_register_card_driver(&es18xx_pnpc_driver);
> > > if (!err) {
> > > - pnp_registered = 1;
> > > + pnpc_registered = 1;
> > > cards += es18xx_pnp_devices;
> > > }
> > > #endif
> >
> > there cards += es18xx_pnp_devices should be outside if (!err) block.
> > Otherwise it's not counted when pnp driver is registered but pnpc
> > driver isn't.
> >
> > Except for that, the patch looks OK.
> > Could you care to create the patch for the latest version of ALSA
> > (either the latest 2.6.18rc or ALSA HG version), together with a
> > summary/comment and a signed-off-by line? Then I'll commit it to ALSA
> > tree.
>
> OK, fixed that and updated the patch to apply to 2.6.18-rc2.
>
> This patch adds PnP BIOS support to es18xx driver. It allows ESS ES18xx sound
> chips integrated in some notebooks (such as DTK FortisPro TOP-5A) that don't
> appear as ISA cards (they aren't recognized by ISA PnP, only by PnP BIOS)
> to "just work" automatically.
>
> Signed-off-by: Ondrej Zary <linux@xxxxxxxxxxxxxxxxxxxx>
Committed to ALSA HG tree now. Thanks.
Takashi
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys -- and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.sourceforge.net/lists/listinfo/alsa-devel
