At Wed, 12 Jul 2006 11:03:51 +0100,
James Courtier-Dutton wrote:
>
> Takashi Iwai wrote:
> > At Tue, 11 Jul 2006 18:28:48 -0400,
> > Lee Revell wrote:
> >
> >> On Wed, 2006-07-12 at 00:12 +0200, James Courtier-Dutton wrote:
> >>
> >>> +const static unsigned char emu1212m_netlist1[] = {
> >>> +0xFF, 0xFF, 0xFF, 0xFF, 0x55, 0x99, 0xAA, 0x66,
> >>> +0x0C, 0x00, 0x01, 0x80, 0x00, 0x00, 0x00, 0xE0,
> >>> +0x0C, 0x80, 0x06, 0x80, 0x00, 0x00, 0x00, 0xD0,
> >>>
> >> [ etc ]
> >>
> >> You're going to bloat everyone's emu10k1 driver with this gigantic
> >> structure? Can't you use the firmware loading interface? The kernel
> >> guys will flip when they see this.
> >>
> >
> > Agreed, that's too big. You should put the binary image in
> > alsa-firmware package and use request_firmware() to read it.
> >
> > Any chance to revert the patch (as exception) from HG tree?
> >
> >
> > Takashi
> >
> I will sort it out this weekend.
> I just wanted to get the code in there so people interested in emu1212m
> support could see it.
> The support for the emu1212m has been a long time coming (years in fact).
The problem is, if you commit codes into alsa-kernel tree, it means
automatically that the code will appear on linux kernel tree.
So, you're pushing unneeded bunch of binary data to the kernel tree
now. The point here is not how well the device is supported.
Takashi
-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.sourceforge.net/lists/listinfo/alsa-devel
