Ben Williamson wrote: > This patch adds a USB MIDI Gadget driver. This driver is glue between > the USB gadget interface and the ALSA MIDI interface. Looks good. (Not that I tested it. ;-) Some remarks below. > +config USB_MIDI_GADGET > + tristate "MIDI Gadget (EXPERIMENTAL)" > + depends on EXPERIMENTAL You need something like this: depends on SND select SND_RAWMIDI > +#include <sound/asequencer.h> This header isn't needed. > + card = snd_card_new(SNDRV_DEFAULT_IDX1, SNDRV_DEFAULT_STR1, THIS_MODULE, 0); Other ALSA drivers have module options for index and id. I could imagine that a synthesizer has another sound card for PCM output; it would make sense for at least the index to be configurable. > +enomem: > + ... > + return -ENOMEM; These error handlers could return err instead. Regards, Clemens Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.sourceforge.net/lists/listinfo/alsa-devel
