At Thu, 29 Jun 2006 14:37:20 +0200,
Mike Rapoport wrote:
>
> +
> +/*
> + * UCB1400 codec
> + */
> +static const struct snd_kcontrol_new snd_ac97_controls_ucb1400[] = {
> +AC97_SINGLE("Headphone driver", 0x6a, 6, 1, 0),
> +AC97_SINGLE("DC filter", 0x6a, 4, 1, 0),
> +AC97_SINGLE("Smart power mode", 0x6c, 4, 3, 0),
What exactly do these controls? Would be nice to have some comments
in the code, too.
Also, words in control names usually begin with capital letters.
Otherwise the patch looks good. Thanks.
Takashi
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.sourceforge.net/lists/listinfo/alsa-devel
