At Thu, 22 Jun 2006 11:47:54 +0800,
jayakumar.alsa@xxxxxxxxx wrote:
>
> Hi Takashi, Jaroslav,
>
> This patch adds two mixer controls. The V_REFOUT disable is a
> documented register that is used to decouple the microphone input
> lines from the DC source. The High Pass Filter disable in the
> AC97_AD_TEST2 (0x5c) is an undocumented register provided by
> Miller Puckette via Analog Devices that is used to prevent the
> AD codec from applying a high pass filter to the input.
Could you implement in a reverse way?
The switch to "disable" a function is confusing. You can set 1 to the
last argument of AC97_SINGLE to invert the bit.
thanks,
Takashi
>
> Thanks,
> Jaya Kumar
>
> Signed-off-by: Jaya Kumar <jayakumar.alsa@xxxxxxxxx>
>
> ---
>
> include/sound/ac97_codec.h | 1 +
> sound/pci/ac97/ac97_patch.c | 2 ++
> 2 files changed, 3 insertions(+)
>
> ---
>
> diff -X cs5535audio.dontdiff -X linux-2.6.17-rc5/Documentation/dontdiff -uprN linux-2.6.17-rc5-ad1888pm/include/sound/ac97_codec.h linux-2.6.17-rc5-ad1888vref/include/sound/ac97_codec.h
> --- linux-2.6.17-rc5-ad1888pm/include/sound/ac97_codec.h 2006-06-18 15:50:59.000000000 +0800
> +++ linux-2.6.17-rc5-ad1888vref/include/sound/ac97_codec.h 2006-06-22 04:06:35.000000000 +0800
> @@ -265,6 +265,7 @@
>
> /* specific - Analog Devices */
> #define AC97_AD_TEST 0x5a /* test register */
> +#define AC97_AD_TEST2 0x5c /* undocumented test register 2 */
> #define AC97_AD_CODEC_CFG 0x70 /* codec configuration */
> #define AC97_AD_JACK_SPDIF 0x72 /* Jack Sense & S/PDIF */
> #define AC97_AD_SERIAL_CFG 0x74 /* Serial Configuration */
> diff -X cs5535audio.dontdiff -X linux-2.6.17-rc5/Documentation/dontdiff -uprN linux-2.6.17-rc5-ad1888pm/sound/pci/ac97/ac97_patch.c linux-2.6.17-rc5-ad1888vref/sound/pci/ac97/ac97_patch.c
> --- linux-2.6.17-rc5-ad1888pm/sound/pci/ac97/ac97_patch.c 2006-06-18 15:40:03.000000000 +0800
> +++ linux-2.6.17-rc5-ad1888vref/sound/pci/ac97/ac97_patch.c 2006-06-22 04:10:25.000000000 +0800
> @@ -1873,6 +1873,8 @@ static const struct snd_kcontrol_new snd
> .get = snd_ac97_ad1888_lohpsel_get,
> .put = snd_ac97_ad1888_lohpsel_put
> },
> + AC97_SINGLE("V_REFOUT Disable", AC97_AD_MISC, 2, 1, 0),
> + AC97_SINGLE("High Pass Filter Disable", AC97_AD_TEST2, 12, 1, 0),
> AC97_SINGLE("Spread Front to Surround and Center/LFE", AC97_AD_MISC, 7, 1, 0),
> {
> .iface = SNDRV_CTL_ELEM_IFACE_MIXER,
>
> All the advantages of Linux Managed Hosting--Without the Cost and Risk!
> Fully trained technicians. The highest number of Red Hat certifications in
> the hosting industry. Fanatical Support. Click to learn more
> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=107521&bid=248729&dat=121642
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@xxxxxxxxxxxxxxxxxxxxx
> https://lists.sourceforge.net/lists/listinfo/alsa-devel
>
All the advantages of Linux Managed Hosting--Without the Cost and Risk!
Fully trained technicians. The highest number of Red Hat certifications in
the hosting industry. Fanatical Support. Click to learn more
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=107521&bid=248729&dat=121642
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.sourceforge.net/lists/listinfo/alsa-devel
