On Thu, May 18, 2006 at 05:43:45PM +0200, Takashi Iwai wrote: > At Thu, 18 May 2006 11:29:14 -0400, > Lee Revell wrote: > > > > Someone pointed out on IRC that this driver has bitrotted and doesn't > > compile with recent kernels. > > > > alsa/alsa-driver-1.0.11/isa/msnd/msnd_pinnacle.c:117: error: expected ) > > before string constant > > > > I think it's due to use of MODULE_PARM which seems to have been removed? > > Already fixed on HG repo. With this fix the driver seems to compile, but won't load because of undefined symbols - trying to compile it for 2.6.17-rc6-git7 gives these warnings: CC [M] .../isa/msnd/msnd.o .../isa/msnd/msnd.c: In function `snd_msnd_init_queue': .../isa/msnd/msnd.c:134: warning: implicit declaration of function `isa_writew' CC [M] .../isa/msnd/msnd_pinnacle.o .../isa/msnd/msnd_pinnacle.c: In function `snd_msnd_play_reset_queue': .../isa/msnd/msnd_pinnacle.c:166: warning: implicit declaration of function `isa_writew' .../isa/msnd/msnd_pinnacle.c: In function `snd_msnd_DARQ': .../isa/msnd/msnd_pinnacle.c:313: warning: implicit declaration of function `isa_readw' .../isa/msnd/msnd_pinnacle.c: In function `snd_msnd_init_sma': .../isa/msnd/msnd_pinnacle.c:623: warning: implicit declaration of function `isa_memset_io' .../isa/msnd/msnd_pinnacle.c:670: warning: implicit declaration of function `isa_writel' .../isa/msnd/msnd_pinnacle.c: In function `upload_dsp_code': .../isa/msnd/msnd_pinnacle.c:720: warning: implicit declaration of function `isa_memcpy_toio' CC [M] .../isa/msnd/msnd_pinnacle_mixer.o .../isa/msnd/msnd_pinnacle_mixer.c: In function `snd_msndmix_set': .../isa/msnd/msnd_pinnacle_mixer.c:204: warning: implicit declaration of function `isa_writeb' .../isa/msnd/msnd_pinnacle_mixer.c:219: warning: implicit declaration of function `isa_writew' .../isa/msnd/msnd_pinnacle_mixer.c:241: warning: implicit declaration of function `isa_readw' CC [M] .../isa/msnd/msnd_midi.o .../isa/msnd/msnd_midi.c: In function `snd_msndmidi_input_drop': .../isa/msnd/msnd_midi.c:312: warning: implicit declaration of function `isa_readw' .../isa/msnd/msnd_midi.c:313: warning: implicit declaration of function `isa_writew' WARNING: "isa_memcpy_toio" [.../isa/msnd/snd-msnd-pinnacle.ko] undefined! WARNING: "isa_memset_io" [.../isa/msnd/snd-msnd-pinnacle.ko] undefined! WARNING: "isa_writeb" [.../isa/msnd/snd-msnd-pinnacle.ko] undefined! WARNING: "isa_writel" [.../isa/msnd/snd-msnd-pinnacle.ko] undefined! WARNING: "isa_writew" [.../isa/msnd/snd-msnd-pinnacle.ko] undefined! WARNING: "isa_readw" [.../isa/msnd/snd-msnd-pinnacle.ko] undefined! Apparently the isa_* functions were removed from kernel: http://kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=57f3ebccaa560d1eeb40b5c719773bed5cb0df46 > > I also notice that this driver is not in the kernel. Could it be added? > > It would allow the OSS driver to be deprecated. > > No, the driver code is too ugly to include to kernel tree. Does someone really maintain this driver?
Attachment:
pgpxmuqCCc3TX.pgp
Description: PGP signature
_______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.sourceforge.net/lists/listinfo/alsa-devel
