On Wed, 2006-06-07 at 20:44 +0200, Takashi Iwai wrote:
> > + if (I2S_CLOCK_SPEED_18MHz % (rate * mclk) == 0) {
> > + if (!i2s_sf_mclkdiv(I2S_CLOCK_SPEED_18MHz / rate / mclk, out)) {
>
> I'd use "I2S_CLOCK_SPEED_18MHZ / (rate * mclk)"
Yeah, I guess that's clearer then if the multiplication is there twice.
> release_resource() doesn't kfree the record returned from
> request_mem_region().
Hah, ouch. I'll go through and fix them all.
> ALSA has a helper function
> release_and_free_resource() that also does NULL check and kfree:
Why's that helper in alsa of all things? :)
johannes
Attachment:
signature.asc
Description: This is a digitally signed message part
_______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.sourceforge.net/lists/listinfo/alsa-devel
