At Sat, 03 Jun 2006 12:39:48 +0100, Adrian McMenamin wrote: > > On Thu, 2006-06-01 at 23:31 +0100, Adrian McMenamin wrote: > > This adds sound for the Yamaha AICA "Super Intelligent Sound > > Processor" (PCM) device on the SEGA Dreamcast > > > > Signed off by Adrian McMenamin <adrian@xxxxxxxxxxxxxxxxx> > > > I've had no comments back on this - I am thinking of committing to the > linux-sh cvs, though it really belongs in ALSA. Sorry for the delay. I've had a long weekend. > Any reason why I shouldn't? As Paul already pointed, the platform_device things must be fixed. Also, better to clean up the code directly accessing hardcoded addresses. Another big concern is that spu_dma_work is initialized/rewritten dynamically in spu_begin_dma() and aica_period_elapsed() via INIT_WORK() and PREPARE_WOR(). This looks pretty strange and may be racy. Takashi _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.sourceforge.net/lists/listinfo/alsa-devel
