Re: ice712 -set mpu401 info flags from card info, patch

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



At Fri, 26 May 2006 16:14:11 +0100,
Alan Horstmann wrote:
> 
> On Friday 26 May 2006 12:11, you wrote:
> > At Wed, 24 May 2006 22:35:31 +0100,
> >
> > Alan Horstmann wrote:
> > > @@ -2736,9 +2737,10 @@
> > >  		}
> > >
> > >  	if (! c->no_mpu401) {
> > > +		c->mpu401_1_info_flags |= MPU401_INFO_INTEGRATED;
> >
> > Don't change the contents of card info here, instead...
> >
> > >  		if ((err = snd_mpu401_uart_new(card, 0, MPU401_HW_ICE1712,
> > > -					       ICEREG(ice, MPU1_CTRL),
> > > -					       MPU401_INFO_INTEGRATED,
> > > +					       ICEREG(ice, MPU1_CTRL),
> > > +					       c->mpu401_1_info_flags,
> >
> > ... add "| MPU401_INFO_INTEGRETED" at this point.
> > (Ditto for mpu401_2_info_flags)
> >
> > Could you repost the fixed patch?
> 
> Fair comment, I shouldn't use it as a variable.  Revised patch attached.
> 
> Alan
> 
> ice1712-mpu401-infoflags-2.patch
> 
> Summary: in ice1712, set mpu401 info flags from _card_info
> 
> To permit use, in ice1712, of the mpu401 info flags recently added to 
> mpu401_uart, adds info_flags in snd_ice1712_card_info so that additional 
> flags can be set, if desired.  'MPU401_INFO_INTEGRATED' is always set with 
> the ice1712.  The flags are passed on to snd_mpu401_uart_new().  _INFO_OUTPUT 
> is set for DMX6fire mpu2.
> 
> Signed-off-by: Alan Horstmann <gineera@xxxxxxxxxxxxxxx>


Applied to HG repo.  I folded too long lines but else applied as is.

Thanks.


Takashi


_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.sourceforge.net/lists/listinfo/alsa-devel


[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux