At Tue, 23 May 2006 10:45:35 +0100, Alan Horstmann wrote: > > [1 <text/plain; iso-8859-1 (quoted-printable)>] > On Monday 22 May 2006 15:05, you wrote: > > At Mon, 22 May 2006 14:52:08 +0100, > > > > Alan Horstmann wrote: > > > Another little 'tidy-up': > > > > > > Have always had the following log message with DMX6fire: > > > > > > linux kernel: Consumer PCM code does not work well at the moment --jk > > > linux kernel: ALSA ac97_codec.c:1671: AC'97 0:0 does not respond - RESET > > > linux kernel: ALSA ac97_codec.c:1682: AC'97 0:0 access is not valid > > > [0xffffffff], removing mixer. > > > linux kernel: ice1712: cannot initialize ac97 for consumer, skipped > > > > > > and thought the last 3 were due to the first. However, after comparing > > > DMX6fire with STDSP24 card, it seems to me that the 6fire doesn't have an > > > AC97 chip, nor anywhere to connect to one in the standard front box, and > > > the W2K drivers from Terratec don't support it. It is remotely possible > > > that other extension boxes may use it -but they do not have alsa support > > > at present. > > > > > > BUT the eeprom data has it enabled. As the value is checked at several > > > places in the code, the attached patch changes the stored value for this > > > and the previous 'Limit ADACs to 6' bits. > > > > > > As a result, the log now shows no evidence of ice1712 driver at all, so I > > > added 'init...done' as in the attached 'init-message' patch. It may be > > > the wrong place, or not wanted at all, so I kept it separate from the > > > AC97 patch. Hope it's OK in this case to attach both here. > > > > Please don't put such printk. We don't put any info print at probe > > unless any problem exists. > > OK, it's your call on this. To me it is useful to log major system events to > look back and see what was happening; there is plenty of much less useful > messsages in the logs, including IP addresses, every root login, and every > second that I don't have a CD in the drive! (need to fix that). The au8820 > driver does a similar init message. But no need for addition. > > Otherwise the change looks OK to get merged, but please fold the > > comment within 80 columns. > > Amended AC97 patch attached. Applied. Thanks. Takashi ------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.sourceforge.net/lists/listinfo/alsa-devel
