[Knut Petersen] [PATCH] fix broken building of guile branch "branch_release-1-8"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



I inadvertantly introduced a bug (actually, two) by following
autoupdate(1)'s suggestion (w/o testing -- that's my fault).

Please see below for details.

My question is: Could this problem be resolved in a more
idiomatic way by using printf(1)?  Something like:

 AC_INIT(m4_esyscmd(. ./GUILE-VERSION && printf %s ${PACKAGE}), ...)

This would avoid echo(1) deficiencies and ‘patsubst’, but would
require printf(1).  I think that's acceptable since i see printf
elsewhere in the generated configure script.  However, i'm not
sure whether or not ‘AC_INIT’ is a special case (being first)...

-------------------- Start of forwarded message --------------------
From: Knut Petersen <Knut_Petersen@xxxxxxxxxxx>
Subject: [PATCH] fix broken building of guile branch "branch_release-1-8"
To: Thien-Thi Nguyen <ttn@xxxxxxx>
Cc: bug-guile@xxxxxxx, lilypond-devel <lilypond-devel@xxxxxxx>
Date: Sun, 21 Mar 2021 18:05:40 +0100

Hi Thien-Thi Nguy,

Two days ago I reported that building of guile branch_release-1-8 failed on my system based on openSuSE Tumbleweed with autoconf 2.71.

I had a look into the case and found that it was introduced by your commits 88155da and c43f252.

The attached patch fixes the problem.

Knut

From 91975e673d179f90eafb0a765968edf27c666961 Mon Sep 17 00:00:00 2001
From: Knut Petersen <knupero@xxxxxxxxx>
Date: Sun, 21 Mar 2021 17:38:24 +0100
Subject: [PATCH] Fix broken building of branch_release-1-8

This fixes problems introduced with
commits 88155da and c43f252.

Signed-off-by: Knut Petersen <knupero@xxxxxxxxx>
---
 configure.ac                | 6 +++---
 guile-readline/configure.ac | 5 ++---
 2 files changed, 5 insertions(+), 6 deletions(-)

diff --git a/configure.ac b/configure.ac
index 9105a43b0..6845dba75 100644
--- a/configure.ac
+++ b/configure.ac
@@ -33,9 +33,9 @@ dnl  "echo -n" since -n is not portable (see autoconf manual "Limitations of
 dnl  Builtins"), in particular on solaris it results in a literal "-n" in
 dnl  the output.
 dnl
-AC_INIT([patsubst(m4_esyscmd(. ./GUILE-VERSION && echo ${PACKAGE}),
-)],[patsubst(m4_esyscmd(. ./GUILE-VERSION && echo ${GUILE_VERSION}),
-)],[bug-guile@xxxxxxx])
+AC_INIT(patsubst(m4_esyscmd(. ./GUILE-VERSION && echo ${PACKAGE}),[
+]),patsubst(m4_esyscmd(. ./GUILE-VERSION && echo ${GUILE_VERSION}),[
+]),[bug-guile@xxxxxxx])
 AC_CONFIG_AUX_DIR([build-aux])
 AC_CONFIG_MACRO_DIR([m4])
 AC_CONFIG_SRCDIR([GUILE-VERSION])
diff --git a/guile-readline/configure.ac b/guile-readline/configure.ac
index fdf9518b6..34fb225d4 100644
--- a/guile-readline/configure.ac
+++ b/guile-readline/configure.ac
@@ -2,9 +2,8 @@ AC_PREREQ([2.71])
 
 dnl Don't use "echo -n", which is not portable (e.g., not available on
 dnl MacOS X).  Instead, use `patsubst' to remove the newline.
-AC_INIT([guile-readline],[patsubst(m4_esyscmd(. ../GUILE-VERSION && echo ${GUILE_VERSION}),
-)],[bug-guile@xxxxxxx])
-
+AC_INIT(guile-readline,patsubst(m4_esyscmd(. ../GUILE-VERSION && echo ${GUILE_VERSION}), [
+]),[bug-guile@xxxxxxx])
 AC_CONFIG_AUX_DIR([.])
 AC_CONFIG_SRCDIR(readline.c)
 AC_CONFIG_HEADERS([guile-readline-config.h])
-- 
2.30.2

-------------------- End of forwarded message --------------------

-- 
Thien-Thi Nguyen -----------------------------------------------
 (defun responsep (query)               ; (2021) Software Libero
   (pcase (context query)               ;       = Dissenso Etico
     (`(technical ,ml) (correctp ml))
     ...))                              748E A0E8 1CB8 A748 9BFA
--------------------------------------- 6CE4 6703 2224 4C80 7502

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [GCC Help]     [Kernel Discussion]     [RPM Discussion]     [Red Hat Development]     [Yosemite News]     [Linux USB]     [Samba]

  Powered by Linux