According to Eric Blake on 2/24/2010 9:05 AM: > According to NightStrike on 2/24/2010 8:48 AM: >> When I ran autoupdate from 2.65 against my configure.ac that I >> manually updated to 2.65, I noticed this change: >> >> -AC_PREREQ([2.65]) >> +AC_PREREQ(2.65) >> >> Why would autoupdate want to remove the quoting about the version number? > > Another instance of a low-priority bug that no one has spent time figuring > out how to patch. Before I log off for the evening, I wanted to post some progress: I'm toying with this (on the surface, I think this is all that is needed to fix things); but still missing is a testsuite addition to prove my suspicions. Help in coming up with a simple test would be appreciated. -- Eric Blake eblake@xxxxxxxxxx +1-801-349-2682 Libvirt virtualization library http://libvirt.org
From 39a3a24f8c49558131f08526796a340d96c40795 Mon Sep 17 00:00:00 2001 From: Eric Blake <eblake@xxxxxxxxxx> Date: Thu, 25 Feb 2010 16:34:17 -0700 Subject: [PATCH] WIP: Properly quote AC_PREREQ during autoupdate. Still needs a test. * lib/autoconf/general.m4 (AC_PREREQ): Follow consistent quoting style for AC_PREREQ. Reported by NightStrike. Signed-off-by: Eric Blake <eblake@xxxxxxxxxx> --- ChangeLog | 7 +++++++ lib/autoconf/general.m4 | 2 +- 2 files changed, 8 insertions(+), 1 deletions(-) diff --git a/ChangeLog b/ChangeLog index 854d7db..db243c7 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,12 @@ 2010-02-25 Eric Blake <eblake@xxxxxxxxxx> + Properly quote AC_PREREQ during autoupdate. + * lib/autoconf/general.m4 (AC_PREREQ): Follow consistent quoting + style for AC_PREREQ. + Reported by NightStrike. + +2010-02-25 Eric Blake <eblake@xxxxxxxxxx> + Update file flow diagram to mention Automake. * doc/autoconf.texi (Making configure Scripts): Avoid confusion with listing Makefile.in twice on one line. Add a diagram showing diff --git a/lib/autoconf/general.m4 b/lib/autoconf/general.m4 index 15640c8..0830bde 100644 --- a/lib/autoconf/general.m4 +++ b/lib/autoconf/general.m4 @@ -298,7 +298,7 @@ m4_define([AC_REVISION], # Autoconf, which is certainly not what the user intended. AU_DEFUN([AC_PREREQ], [m4_version_prereq([$1])[]dnl -[AC_PREREQ(]]m4_defn([m4_PACKAGE_VERSION])[[)]]) +[AC_PREREQ(]]m4_dquote(m4_defn([m4_PACKAGE_VERSION]))[[)]]) # AC_PREREQ(VERSION) -- 1.6.6.1
Attachment:
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Autoconf mailing list Autoconf@xxxxxxx http://lists.gnu.org/mailman/listinfo/autoconf
