Re: questions about AC_CONFIG_MACRO_DIR

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello again,

Ralf has told me that I should be more careful about
AC_CONFIG_AUX_DIR.  Though it sounds weird, the possibility to call
it with an absolute directory name is documented, so I cannot remove
the comment.  (And I think it's not worth the hassle to `obsolete'
this feature.)

The rest of my previous mail still holds:

On Wed, Sep 13, 2006 at 07:05:52PM +0200, Stepan Kasal wrote:
> On Tue, Sep 12, 2006 at 02:55:51PM -0700, Paul Eggert wrote:
> > Why get rid of ac_macro_dir entirely?  Is it harmful?  (or pointless? :-)
> 
> I believe it is pointless; no one uses it, and I cannot see any
> reason why one would need it at configure time.
> 
> Attached please find an updated version of the patch.
> 
> Paul, I also suggest to edit your changelog entry, because I cannot
> imagine a case where the macro dir is an absolute path.  That would
> effectively mean that the distribution does not contain all primary
> sources, and we should not encourage that.
> 
> OK to commit?

Stepan
2006-09-12  Stepan Kasal  <kasal@xxxxxx>

	* lib/autoconf/general.m4 (AC_CONFIG_MACRO_DIR): Remove a
          mistaken comment: the path has to be relative; do not use
	  the path at runtime.

Index: ChangeLog
===================================================================
RCS file: /cvsroot/autoconf/autoconf/ChangeLog,v
retrieving revision 1.3031
diff -u -r1.3031 ChangeLog
--- ChangeLog	13 Sep 2006 04:48:23 -0000	1.3031
+++ ChangeLog	13 Sep 2006 17:02:32 -0000
@@ -13,8 +13,7 @@
 	* doc/autoconf.texi (Input): Clarify role of AC_CONFIG_MACRO_DIR.
 	* lib/autoconf/general.m4 (AC_CONFIG_MACRO_DIR): Do not check
 	for the existence of the directory at configure-time.  That's
-	too late, anyway, and possibly the directory isn't part of the
-	distribution.  Problem reported by Stefan Seefeld.
+	too late, anyway.  Problem reported by Stefan Seefeld.
 
 	* lib/m4sugar/m4sh.m4 (_AS_TEST_PREPARE): Avoid bug in UnixWare
 	7.1.4 /usr/bin/posix/sh described by Tim Rice in
Index: lib/autoconf/general.m4
===================================================================
RCS file: /cvsroot/autoconf/autoconf/lib/autoconf/general.m4,v
retrieving revision 1.929
diff -u -r1.929 general.m4
--- lib/autoconf/general.m4	12 Sep 2006 18:16:34 -0000	1.929
+++ lib/autoconf/general.m4	13 Sep 2006 17:02:35 -0000
@@ -1627,13 +1627,7 @@
 # AC_CONFIG_MACRO_DIR(DIR)
 # ------------------------
 # Declare directory containing additional macros for aclocal.
-# DIR can be either absolute or relative to $srcdir.
-AC_DEFUN([AC_CONFIG_MACRO_DIR],
-[case $1 in
-  [[\\/]]* | ?:[[\\/]]* ) ac_macro_dir=$1         ;;
-  *)                      ac_macro_dir=$srcdir/$1 ;;
-esac[]dnl
-])# AC_CONFIG_MACRO_DIR
+AC_DEFUN([AC_CONFIG_MACRO_DIR], [])
 
 
 
_______________________________________________
Autoconf mailing list
Autoconf@xxxxxxx
http://lists.gnu.org/mailman/listinfo/autoconf

[Index of Archives]     [GCC Help]     [Kernel Discussion]     [RPM Discussion]     [Red Hat Development]     [Yosemite News]     [Linux USB]     [Samba]

  Powered by Linux