Re: lib_LIBRARIES must be set with `=' before using `+='

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Harald Dunkel wrote:

This is my suggestion:

--- ../old/automake-1.9.5/lib/Automake/VarDef.pm 2004-09-21 20:20:34.000000000 +0200
+++ lib/Automake/VarDef.pm 2005-02-24 09:07:21.106214815 +0100
@@ -152,7 +152,7 @@


   # A user variable must be set by either `=' or `:=', and later
   # promoted to `+='.
-  if ($owner != VAR_AUTOMAKE && $type eq '+')
+  if (0 && $owner != VAR_AUTOMAKE && $type eq '+')
     {
       error $location, "$var must be set with `=' before using `+='";
     }

I know it is rude. Probably the user variables with a
default value != "" will not work as expected, if I got
the code correctly. Are there any other problems to be
expected by this patch? ("make check" reported just
the pluseq7.test.)


I've been using this for quite some time in a modular system (based upon an arbitrary set of "include xyz/Makefile.inc" in a generated top level Makefile.am).

There were no visible disadvantages, so I wonder whether it
would be possible to include this change into the official
source tree?


Regards

Harri


_______________________________________________ Autoconf mailing list Autoconf@xxxxxxx http://lists.gnu.org/mailman/listinfo/autoconf

[Index of Archives]     [GCC Help]     [Kernel Discussion]     [RPM Discussion]     [Red Hat Development]     [Yosemite News]     [Linux USB]     [Samba]

  Powered by Linux